[Flink] Forward customer-provided fs.* options to the engine config#7048
Open
harperjiang wants to merge 3 commits into
Open
[Flink] Forward customer-provided fs.* options to the engine config#7048harperjiang wants to merge 3 commits into
harperjiang wants to merge 3 commits into
Conversation
KaiqiJinWow
approved these changes
Jun 18, 2026
ChengJiX
approved these changes
Jun 18, 2026
6c74177 to
5d2446f
Compare
TableConf.engineConf() previously returned an empty map, so file-system options a customer set as table options (e.g. fs.s3a.access.key, fs.azure.account.key.<acct>) never reached the Hadoop Configuration that AbstractKernelTable builds for the Delta Kernel engine. Copy every customer-provided key prefixed with "fs." into engineConf(), mirroring the prefix-filter pattern already used by catalogConf(). These are applied after the built-in fs.* defaults (so customer values override them) and before vended credentials (so credentials still win on collision) in AbstractKernelTable.createEngine(). Add TableConfTest covering fs.* inclusion, non-fs exclusion, the empty case, and keys added later via update(). Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TableConf.engineConf()previously returned an empty map, so file-system options a customer sets as table options (e.g.fs.s3a.access.key,fs.azure.account.key.<acct>.dfs.core.windows.net) never reached the HadoopConfigurationthatAbstractKernelTablebuilds for the Delta Kernel engine.This change copies every customer-provided key prefixed with
fs.intoengineConf(), mirroring the prefix-filter pattern already used bycatalogConf().Precedence
In
AbstractKernelTable.createEngine()these options are applied:fs.*defaults → customer values override the defaultsThe apply order is unchanged.
Tests
New
TableConfTestcovers:fs.*keys are forwardedfs.keys (delta.*,io.unitycatalog.*,checkpoint.frequency) are excludedfs.*keys are presentupdate(...)are picked upValidation (per flink/skills.md)
build/sbt "flink / javafmt"— clean, no changesbuild/sbt "flink / Test / javafmt"— clean, no changesbuild/sbt "flink / test"— 202 total, 0 failed, 198 passed, 4 skippedbuild/sbt "flink / Compile / doc"— successNote
This forwards all
fs.*options verbatim, including any secrets a customer supplies as table options. That is consistent with how the built-in defaults and vended credentials already flow into the engineConfiguration.Tracking: #5901
This pull request and its description were written by Isaac.